github-actions[bot] commented on code in PR #69271:
URL: https://github.com/apache/doris/pull/69271#discussion_r4322477836
##########
be/src/exprs/function/function_date_or_datetime_computation.cpp:
##########
@@ -435,23 +409,6 @@ void
register_function_date_time_computation(SimpleFunctionFactory& factory) {
REGISTER_ALL_DATEV2_FUNCTIONS_DIFF(FunctionDatetimeMilliSecondsDiff)
REGISTER_ALL_DATEV2_FUNCTIONS_DIFF(FunctionDatetimeMicroSecondsDiff)
factory.register_function<FunctionTimeStampNsNanoSecondsDiff>();
Review Comment:
[P1] Retain mixed temporal kernels for older frontends
During the documented [BE-first rolling
upgrade](https://doris.apache.org/docs/4.x/admin-manual/cluster-management/upgrade/),
the current `branch-4.2` FE (`ddc988bc458`, `be_exec_version=14`) still lowers
`SELECT seconds_diff(ts, dt) FROM t`, with `ts TIMESTAMP_NS` and `dt
DATETIMEV2(6)`, to `Project(seconds_diff(ts, dt)) -> Scan(t)` with distinct
operand types: its `SecondsDiff` explicitly declares that mixed signature. This
BE still accepts exec version 14, but deleting these registrations removes the
`seconds_diffTimeStampNsDateTimeV2` factory entry, so
`VectorizedFnCall::prepare` returns `Could not find function` even when both
columns contain ordinary 2024 dates. These queries therefore fail after
upgrading BEs and before upgrading FEs. Please retain the legacy mixed kernels
for older plans alongside the new FE normalization, and cover this
exec-version-14 producer/consumer combination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
