github-actions[bot] commented on code in PR #69312:
URL: https://github.com/apache/doris/pull/69312#discussion_r4321123092
##########
fe/fe-core/src/main/java/org/apache/doris/persist/gson/GsonUtils.java:
##########
@@ -447,7 +444,6 @@ public class GsonUtils {
.registerSubtype(MaxComputeExternalCatalog.class,
MaxComputeExternalCatalog.class.getSimpleName())
.registerSubtype(
TrinoConnectorExternalCatalog.class,
TrinoConnectorExternalCatalog.class.getSimpleName())
- .registerSubtype(LakeSoulExternalCatalog.class,
LakeSoulExternalCatalog.class.getSimpleName())
.registerSubtype(LanceExternalCatalog.class,
LanceExternalCatalog.class.getSimpleName())
Review Comment:
[P1] Keep old catalog images readable until DROP replay
A successful `DROP CATALOG` before upgrading does not guarantee that the
latest image no longer contains the LakeSoul catalog:
`CatalogMgr.dropCatalog()` removes the live entry and journals the drop, while
checkpoints run asynchronously. If the last image predates that drop, startup
calls `Env.loadImage()` before opening/replaying the edit log, and removing
this subtype makes `RuntimeTypeAdapterFactory.read()` throw on
`LakeSoulExternalCatalog`. The FE therefore cannot start or replay the
already-committed drop, even when the operator followed the release note. Keep
a metadata-only deserialization path, including nested LakeSoul metadata, so
startup can replay dropped catalogs without retaining LakeSoul read support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
