morningman opened a new pull request, #4409:
URL: https://github.com/apache/doris-website/pull/4409

   ## Why
   
   Korean generation has been manual-only (`workflow_dispatch`) since the 
workflow was added in #4358. All 3336 Korean target documents (Dev 1670, 4.x 
1615, community 51) are now translated, merged and served in production. From 
here the workflow needs to keep them current as the English sources change, the 
same way the Japanese workflow does.
   
   ## What changed
   
   ### 1. Schedule
   
   `korean-translation.yml` now also runs at 04:43 and 16:43 UTC, twenty 
minutes after the Japanese schedule (04:23 and 16:23). Both workflows already 
share the `japanese-translation-ja` concurrency group with `cancel-in-progress: 
false` and `queue: max`, so a Korean run waits while a Japanese run is still 
working and never uses the Codex auth pool at the same time.
   
   ### 2. Scheduled runs generate
   
   Scheduled runs have no inputs, so the mode fell back to `dry-run`. But 
`workflow-scan.cjs` treats every scheduled run as eligible, while 
`workflow-generate.cjs` only runs in `generate` mode. With the old fallback, a 
scheduled run with a pending document would have reached the generation step 
and failed after loading Codex auth. The fallback is now `generate`, matching 
the Japanese workflow. Manual dispatch still defaults to `dry-run`.
   
   ### 3. Tests
   
   `korean-workflow.test.cjs` now asserts the schedule (and that it stays 
offset from the Japanese one) and the new fallback. A new test passes the mode 
a scheduled run resolves to into `allowGeneration`. With the old `dry-run` 
fallback, both tests fail.
   
   ### 4. Docs
   
   `translations/README.md` still described the workflow as manual-only and 
production as Japanese-only. Both statements are updated.
   
   Unchanged: the planner limit (20) and batch size (10), open-PR 
reconciliation and deduplication, protection of human-owned targets, the 
`translate-ko` label check before auth loading, and the PR admission checks. 
Maintainers review and merge generated PRs as before; nothing is merged 
automatically.
   
   ## Verification
   
   - `node --test` on Node 20.20.2: `korean-workflow` 5/5, `workflow` 29/29, 
`multi-locale` 6/6.
   - Mutation check: restoring the `dry-run` fallback fails the two updated 
assertions.
   - Scheduled discovery replayed locally on this branch 
(`GITHUB_EVENT_NAME=schedule`, `I18N_MODE=generate`, `I18N_LOCALE=ko`): 38 open 
PRs, 0 relevant; required 3336, merged current 3336, pending 0; selected 0, 
`can_generate=false`. On today's state, a scheduled run scans and skips 
generation without calling the model.
   
   ## After merge
   
   The first scheduled run will be checked for its trigger time, lock and queue 
behaviour, discovery summary, and that generation is skipped while nothing is 
pending.
   
   Rollback: remove the `schedule` block. Manual dispatch keeps working either 
way.
   
   🤖 Generated with [Claude Code](https://claude.com/claude-code)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to