mrhhsg commented on PR #69309:
URL: https://github.com/apache/doris/pull/69309#issuecomment-6281791839
<!-- autopilot-response -->
Reviewed the current review state at head
`a7b8de3771412097470b8ac27a2909e78c26ed5b`.
- `IC_kwDOBfSlxs8AAAABdms5xw` (contribution checklist prompt): the PR
description already covers the requested points.
1. Problem and root cause: with nested column pruning, a map nested in a
struct could be lazily materialized with only its keys or only its values after
a sibling struct field was used for filtering. The map placeholder is cleared
during the lazy phase, but the skipped key/value counterpart stayed empty, so
the `ColumnMap` offsets no longer matched both child column sizes; on this
branch it surfaces as a `ColumnVector<T>::insert_range_from` out-of-range error.
2. Behavior: before the fix such pruned lazy map reads could fail; now
`MapFileColumnIterator::next_batch` / `read_by_rowids` fill only the truly
skipped counterpart with defaults during lazy materialization, keep the child
data already read in the predicate phase, and still skip the pruned data pages.
3. New features: none; this is a bug fix only.
4. Refactoring: the duplicated key/value read loops in `read_by_rowids`
are folded into one local helper as part of the fix, not an unrelated refactor.
5. Optimization: none; the pruned pages are still not read.
- `IC_kwDOBfSlxs8AAAABdms61A` (`/review`): this is the review trigger
comment. The automated review for this head is still running and has not
produced findings yet, so there is nothing to fix from this comment.
There are no unresolved inline review threads on this PR. No code changes
were made in this round and the branch head is unchanged. Could a human
reviewer take another look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
