starocean999 opened a new pull request, #69305:
URL: https://github.com/apache/doris/pull/69305
Problem Summary:
Audit events for `INSERT INTO ... SELECT` always had an empty `sql_digest`.
Digest generation only ran inside the `is_query` branch of `AuditLogHelper`,
while INSERT is a Nereids `Command` and therefore has `is_query=false`.
`InsertIntoTableCommand.toDigest()` already exists, but it represents the whole
INSERT statement and includes the write sink.
This change:
- Adds `AuditDigestProvider` for non-query commands that need an audit
fingerprint.
- Extracts the SELECT-only digest from the original parser plan in
`InsertUtils.getSelectDigestForAudit`: the write sink is excluded, a CTE is
preserved, and literals stay normalized. Write-time casts and default columns
are not included.
- Decouples audit digest generation from the query metrics branch in
`AuditLogHelper`. `updateMetricsImpl` remains query-only, and `is_query` is
unchanged.
- Keeps `sql_digest` empty for `INSERT ... VALUES` because there is no
SELECT semantics to fingerprint.
As a result, `INSERT INTO t SELECT ...` gets the same digest as the
equivalent standalone SELECT. This PR intentionally scopes to `INSERT INTO ...
SELECT`; `INSERT OVERWRITE ... SELECT`, `INSERT INTO TVF ... SELECT`, and the
legacy planner are not covered.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
