HappenLee commented on PR #67762: URL: https://github.com/apache/doris/pull/67762#issuecomment-6265959876
/review Please review the full updated PR at ad135bf83bfcdbe6995b1cdb2229e51da3119b8f, especially the fixes for P1-1 (post-admission error publication and RPC lifetime) and P1-3 (observable TaskExecutor rejection and external-parent progress). Both threads have detailed fix/test replies and are resolved. P1-2 / Workload Group isolation (discussion_r4025047077) is not fixed by this revision and remains an existing concern. The shared-pool progress test is not a two-group isolation test. Validation: all 59 related ASAN BE unit tests passed, including six new failure-path tests and an expanded active-read lifetime test. clang-format 16, build hygiene, git diff --check, and clang-tidy on changed lines passed. The clang-tidy run used a temporary VFS overlay to remove one pre-existing unmatched suppression comment; the unrelated source file was not modified. SQL regression, cold-storage integration, and performance benchmarks were not run in this revision. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
