morningman commented on PR #69295: URL: https://github.com/apache/doris/pull/69295#issuecomment-6273257252
Addressed the review in 0037d011cdb. Both findings were regressions of this PR and are fixed here; each reproduced on a local cluster before the fix. Per finding: - [P1] Normalize ORC keys in the global-index bootstrap: the writer now pads the bootstrapped keys of a cross-partition table that writes ORC files, as it pads the rows it writes, and keeps the partition values as they are stored. Covered by a unit test that bootstraps a real ORC table, and by the regression `orc_cross_partition_upsert`, with keys written by Doris and by Spark. - [P1] Preserve the MERGE guard: CHAR partition keys and tables without ORC files keep the short-key check of #69083. Tables whose every level writes ORC keep this PR's trailing-space check. Tables that write ORC at some levels only now reject both. Covered by unit tests and by the regressions `orc_partition_key_merge` and `avro_level0_*`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
