mrhhsg commented on PR #68125: URL: https://github.com/apache/doris/pull/68125#issuecomment-6262909945
<!-- autopilot-response --> Handled HappenLee's two review threads on the read-time hidden column change. - `read_time_hidden_column.cpp`: VERSION/COMMIT_TSO resolution is now shared with `Segment::_get_column_reader_for_read()`; the pre-publish physical-read case and the separate BINLOG_TSO semantics are preserved. A singleton rowset with an unusable TSO now errors instead of returning the stored placeholder. - `rowid_fetcher.cpp`: constant fills now use a batched `ColumnVector::insert_duplicate_fields()` instead of one `insert(Field)` per row. The fixes are in commits 522030c7761 and 83a2f010c59. Verification: BE UT 43/43 passed; local regression `point_query_p0/test_point_query_read_time_hidden_columns` and `inverted_index_p0/test_build_index_read_time_hidden_column` passed. @HappenLee could you take another look when you have a chance? Thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
