mrhhsg commented on PR #69270: URL: https://github.com/apache/doris/pull/69270#issuecomment-6262514689
<!-- autopilot-response --> Re-checked the full review history at HEAD `8c41a7ccfc839d353753e67f6a5e6581e7223493`. No code change was required in this round. - `mrhhsg`'s `/review` is the review trigger command, not a finding. At this HEAD there are no review findings and no inline review threads (0 reviews, 0 threads). - `hello-stephen`'s template asks for a clear PR description. The PR body already covers all requested points: the data race between `stop_if_finished()` and `finalize()` on `_sink`, the fix (copy the `shared_ptr` under `_dependency_lock`, skip already-finalized tasks, call `terminate()` only after releasing the lock), the branch-4.2 adaptations (`_dependency_lock` rather than master's `_dependency_lifecycle_lock`, `terminate()` rather than `unblock_all_dependencies()`), behavior changes (none), and tests. - The branch-4.2 code is unchanged and still matches the reviewed commit; the worktree has no tracked changes. **Validation at this HEAD:** `./run-be-ut.sh --run -j 48 --filter='PipelineTaskTest.*'` -> 23/23 passed, including `PipelineTaskTest.TEST_STOP_IF_FINISHED_EXCLUDES_FINALIZE`. The PR remains ready for review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
