github-actions[bot] commented on code in PR #68307: URL: https://github.com/apache/doris/pull/68307#discussion_r4310951748
########## regression-test/suites/datatype_p0/nested_types/ddl/test_struct_nested_comment_ddl.groovy: ########## @@ -0,0 +1,50 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +suite("test_struct_nested_comment_ddl", "p0") { + sql "DROP TABLE IF EXISTS struct_nested_comment" + sql "DROP TABLE IF EXISTS struct_nested_comment_replay" + sql "DROP TABLE IF EXISTS struct_nested_comment_like" + + // The comment on b carries a single quote and a back slash, both have to survive the DDL. + sql """ + CREATE TABLE struct_nested_comment ( + id INT, + s STRUCT<a:INT, b:TEXT COMMENT "owner''s \\\\path", c:INT> COMMENT "top-level", + n STRUCT<lvl1:STRUCT<lvl2:INT COMMENT "deep doc">>, + arr ARRAY<STRUCT<inside:INT COMMENT "in array">> + ) + DUPLICATE KEY(id) + DISTRIBUTED BY HASH(id) BUCKETS 1 + PROPERTIES ("replication_num" = "1") + """ + + // SHOW CREATE TABLE used to drop every nested field comment. + qt_show_create "SHOW CREATE TABLE struct_nested_comment" Review Comment: [P2] Normalize SHOW properties before recording the expected row This suite runs in Cloud p0: its configuration selects `p0` and excludes neither this suite nor `datatype_p0`. However, this `qt_` call compares the entire DDL with an output containing non-Cloud replication properties. In Cloud mode, `Env.addOlapTablePropertyInfo` emits `file_cache_ttl_seconds` instead of `replication_allocation`/`min_load_replica_num`, and the framework does no automatic SHOW normalization. The suite therefore fails here before reaching either round-trip check, even when nested comments are correct. Capture the stable column/comment text with a row converter and regenerate the expected output. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
