Gabriel39 commented on PR #69163: URL: https://github.com/apache/doris/pull/69163#issuecomment-6248013309
Addressed the three latest review findings and all three FE UT failures reported for 7f5dc6148cd. - Emit typed UUID literals for both Presto and Trino, with equality and IN/NOT IN serialization tests. - Validate dynamic map UUID leaves through an intermediate type that preserves non-UUID source types. The ordinary sink cast still controls numeric narrowing, and volatile sources are evaluated once. - Parse serialized ARRAY/MAP/STRUCT inputs with UUID leaves retained as text, then validate those leaves before ordinary sink coercion. Cover invalid text, valid compact UUIDs, nested values and nulls. - Update the metadata-modification fixtures to native UUID, including UUID array elements, while preserving their existing schema-validation assertions. Validation: 73 focused FE tests passed, including the complete IcebergMetadataOpsValidationTest class; FE Checkstyle passed. The expanded test_iceberg_write_uuid_inputs regression passed in comparison mode for both Parquet and ORC, using the CI ASAN BE and the freshly compiled FE classes. The original code reproduced the map overflow exception and serialized invalid UUID values becoming NULL. No golden files were changed. The separate check_coverage_fe failure in build 1072212 exits with code 4 during Maven bootstrap download, before compilation or coverage calculation. A new build and review have been requested for this update; their results are still pending. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
