yiguolei commented on code in PR #16822:
URL: https://github.com/apache/doris/pull/16822#discussion_r1108342805
##########
be/src/vec/olap/vcollect_iterator.cpp:
##########
@@ -166,15 +158,17 @@ Status
VCollectIterator::build_heap(std::vector<RowsetReaderSharedPtr>& rs_reade
++iter;
}
}
- _inner_iter.reset(new Level1Iterator(_children, _reader, _merge,
_is_reverse, _skip_same));
+ _inner_iter.reset(
+ new Level1Iterator(std::move(_children), _reader, _merge,
_is_reverse, _skip_same));
}
RETURN_IF_NOT_EOF_AND_OK(_inner_iter->init());
// Clear _children earlier to release any related references
_children.clear();
return Status::OK();
}
-bool VCollectIterator::LevelIteratorComparator::operator()(LevelIterator* lhs,
LevelIterator* rhs) {
+bool VCollectIterator::LevelIteratorComparator::operator()(LevelIteratorSPtr
lhs,
Review Comment:
use shared ptr here may be very slow
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
