abhinav-phi commented on PR #68731: URL: https://github.com/apache/doris/pull/68731#issuecomment-6220158412
@morrySnow all four of the review findings are now answered in the thread, with the code at 8da19ea9. two things I cannot do myself on this branch: the push that carried those fixes dismissed your earlier approval, so the pr needs a fresh +1 from a committer. and the GitHub Actions runs on this head are still sitting at action_required, 16 of them, created 2026-10-14T20:08Z, none with a single job. as a first time contributor I cannot approve them. could someone approve and run them, and if it is easier `run buildall` on 8da19ea9 so the FE UT and regression suites report against this head rather than the old one. nothing is red right now, it is that nothing has ever executed on this head. the one open question I am deliberately leaving to you is on the second signed zero finding: I put the value equality override on DoubleLiteral rather than on Literal so this branch does not move equality for every literal type. FloatLiteral still compares bits today. if you would rather that rule live on Literal, say so and I will move it in this branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
