re20052 commented on PR #66187: URL: https://github.com/apache/doris/pull/66187#issuecomment-6206433702
> I have reviewed all of the AI review comments on this PR and addressed the issues that require fixes. I do not believe the remaining three comments need to be handled in this PR: > > The first concerns additional RPCs and planning overhead in Cloud mode when the partition-version cache TTL is set to zero. It does not affect query correctness and is a lower-priority performance issue, so I do not plan to address it in this PR. The second concerns a semantic boundary: whether partitions written within the current transaction but not yet committed should participate in the selection. max_visible_partition() currently selects partitions based only on published visibleVersion values. Therefore, partitions containing only uncommitted writes from the current transaction are intentionally excluded. The third concerns SQL Cache potentially retaining an incorrect partition selection under a specific combination of Cloud mode, TTL settings, and execution timing. This issue was not introduced by this PR. The existing empty-partition pruning path for ordinary queries is exposed to the same risk. It should therefore be tracked and addressed separately rather than treated as a blocker for this PR. I have reviewed all of the AI review comments on this PR and addressed the issues that require fixes. I do not believe the remaining three comments need to be handled in this PR: The first concerns additional RPCs and planning overhead in Cloud mode when the partition-version cache TTL is set to zero. It does not affect query correctness and is a lower-priority performance issue, so I do not plan to address it in this PR. The second concerns a semantic boundary: whether partitions written within the current transaction but not yet committed should participate in the selection. max_visible_partition() currently selects partitions based only on published visibleVersion values. Therefore, partitions containing only uncommitted writes from the current transaction are intentionally excluded. The third concerns SQL Cache potentially retaining an incorrect partition selection under a specific combination of Cloud mode, TTL settings, and execution timing. This issue was not introduced by this PR. The existing empty-partition pruning path for ordinary queries is exposed to the same risk. It should therefore be tracked and addressed separately rather than treated as a blocker for this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
