morningman commented on PR #68825: URL: https://github.com/apache/doris/pull/68825#issuecomment-6175021011
Thanks for the update. I re-read 446fd368cc1 against my earlier comment: points 1, 2, 4 and 5 are addressed, and most of the 4.x FE tests are now ported. What remains: - **Merge conflict with master.** #69045 has merged the same CHAR/VARCHAR length and DATETIME precision mapping (e771daa9b01), so `PaimonTypeMapping.java` and `PaimonTypeMappingToPaimonTest.java` conflict. Every TeamCity job on 446fd368cc1 stopped at `merge refs/pull/68825/head into master failed`, before compiling anything. Rebasing onto master and dropping this branch's copy of the mapping should unblock them. - **Routing.** With an aggregate pushed down a split now stays native, as in 4.x. Without one, a split that can be read natively still goes to Rust first, while 4.x lets Rust replace only JNI. - **Description.** The fallbacks that differ from 4.x (COUNT(*) ranges, access paths deeper than one level, TIMESTAMP(7..9)) are explained in the selector's Javadoc but not in the PR description; listing them there, with the routing difference above, would help reviewers. - **Tests still without a counterpart** (by name, against 4.x): `testPrimaryKeyMergeEnginesWithOneInsertOnlyFile`, the query-auth, REST token and environment credential provider cases, the mixed-format ORC LTZ case, and the primary-key deletion-vector level-0 / delete matrix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
