wenzhenghu commented on code in PR #68740:
URL: https://github.com/apache/doris/pull/68740#discussion_r4267288061
##########
be/src/service/doris_main.cpp:
##########
@@ -505,12 +515,14 @@ int main(int argc, char** argv) {
}
if (paths.empty()) {
+ doris::DiskHealthCheckWatchdog::ScopedCheck
check(startup_disk_watchdog);
Review Comment:
Added comments at both startup failure scopes in
[04d211fa61bd](https://github.com/apache/doris/commit/04d211fa61bdd16bc288a448379c0de6f97021d4).
They explicitly explain that `exit()` does not unwind the scope and that the
deadline covers logging, atexit handlers, and teardown.
That is intentional: the failure path must still terminate if logging or
destruction blocks. It can change the final status to 74 when enabled, which is
now documented rather than presented as only a disk-probe deadline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
