Gabriel39 opened a new pull request, #66: URL: https://github.com/apache/doris-shade/pull/66
Shading keeps only the first resource when dependencies use the same license filename. This drops the CDDL text from `javax.transaction:jta:1.1` while retaining all 18 of its classes, and also loses license content from other bundled dependencies. Append the license resources at `META-INF/LICENSE`, `META-INF/LICENSE.txt`, and `LICENSE` so every original text survives. Add a binary-license note pointing readers to the retained texts, including JTA's CDDL terms. Validation: - `mvn -B -ntp clean verify` passed. - Checked 71 license resources from 110 included dependencies: 21 original texts were not fully retained before the fix; all 71 are retained after it. - Compared the rebuilt JAR with the existing candidate: all 68,901 class files are byte-identical. Only the three license resources and the version-bearing manifest differ. - SkyWalking Eyes passed on the staged source tree: 4 valid, 0 invalid, 6 ignored. - `git diff --check` passed. This fixes license-resource loss during shading; it does not claim a complete license audit of dependencies that do not ship their own license text. A new release candidate must be built from the merged fix. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
