OIiveirra commented on code in PR #68811:
URL: https://github.com/apache/doris/pull/68811#discussion_r4278568814
##########
fe/fe-core/src/test/java/org/apache/doris/cloud/CacheHotspotManagerTableFilterTest.java:
##########
@@ -974,8 +974,8 @@ public void testShouldWarmUpPerformanceMultipleRules50k() {
// Result = 11000 - 11*100 = 9900
Assertions.assertEquals(9900, matched);
System.out.println("[Perf] 50K tables, include+exclude: " + elapsedMs
+ " ms, matched=" + matched);
- Assertions.assertTrue(elapsedMs < 500,
- "50K regex matches (multi-rule) should complete within 500ms,
took " + elapsedMs + " ms");
+ Assertions.assertTrue(elapsedMs < 750,
+ "50K regex matches (multi-rule) should complete within 750ms,
took " + elapsedMs + " ms");
Review Comment:
Thanks for pointing this out. The timing relaxation came from earlier CI
troubleshooting and is unrelated to JDBC diagnostics, so it should not be part
of this PR. Reverted both changes in cac49fca671: the 50K multi-rule limit is
back to 500 ms and the 200K many-rule limit is back to 3 s. This file now has
no diff against master. All 36 CacheHotspotManagerTableFilterTest tests passed
with the restored limits; standalone FE Checkstyle passed.
##########
fe/fe-core/src/test/java/org/apache/doris/cloud/CacheHotspotManagerTableFilterTest.java:
##########
@@ -974,8 +974,8 @@ public void testShouldWarmUpPerformanceMultipleRules50k() {
// Result = 11000 - 11*100 = 9900
Assertions.assertEquals(9900, matched);
System.out.println("[Perf] 50K tables, include+exclude: " + elapsedMs
+ " ms, matched=" + matched);
- Assertions.assertTrue(elapsedMs < 500,
- "50K regex matches (multi-rule) should complete within 500ms,
took " + elapsedMs + " ms");
+ Assertions.assertTrue(elapsedMs < 750,
+ "50K regex matches (multi-rule) should complete within 750ms,
took " + elapsedMs + " ms");
Review Comment:
Addressed in cac49fca671. Removed the unrelated cloud performance-threshold
relaxations from this PR and restored the master values (500 ms / 3 s). The
file now matches master, and all 36 tests in CacheHotspotManagerTableFilterTest
passed. The other fixes remain scoped to JDBC diagnostic reporting and its
plugin compatibility requirements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
