qidaye commented on code in PR #16800:
URL: https://github.com/apache/doris/pull/16800#discussion_r1107941736
##########
fe/fe-core/src/main/java/org/apache/doris/external/elasticsearch/QueryBuilders.java:
##########
@@ -38,6 +59,238 @@
*/
public final class QueryBuilders {
+ /**
+ * Generate dsl from compound expr.
+ **/
+ private static QueryBuilder toCompoundEsDsl(Expr expr, List<Expr>
notPushDownList,
+ Map<String, String> fieldsContext, boolean likePushdown) {
Review Comment:
> should we use a `BuilderOptions` or `BuilderContext` to wrap the `boolean
likePushdown` if it has more option later?
Good idea.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
