AntiTopQuark opened a new pull request, #69080:
URL: https://github.com/apache/doris/pull/69080
### What problem does this PR solve?
Issue Number: close #69079
Related PR: #xxx
Problem Summary:
Extending ROW binlog TTL could race with concurrent replica cloning or
repair. FE checked only partition IDs after sending configuration updates, so
newly added or replaced replicas could be missed. Meanwhile, cloned tablet
headers could retain the old TTL or overwrite an already acknowledged
configuration. FE could therefore publish a longer retention window while a
replica continued compacting with the shorter TTL, causing irreversible, silent
loss of binlog events.
This change persists the pending retention target, carries the versioned
BinlogConfig through clone tasks, and installs it before exposing cloned
tablets to TTL cleanup. Configuration updates are serialized with clone and
migration operations. FE rechecks replica identities and repeats the
acknowledgment round when replicas change, and validates the installed
configuration during clone completion and report-based replica adoption.
Replacement clones also rebuild stale local replicas whose binlog history may
already have been compacted.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [x] Regression test
- [x] Unit Test
- [x] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [x] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
