jacktengg opened a new pull request, #69078:
URL: https://github.com/apache/doris/pull/69078
### What problem does this PR solve?
Issue Number: N/A
Related PR: N/A
Problem Summary: SELECT ARRAY_SORT((x, y) -> y - x, ARRAY(1, 3, 2)) crashes
BE and surfaces as an RPC failure. The comparator returns a nullable SMALLINT,
while array_sort casts its result directly to ColumnInt8. Unwrapping nullable
alone still leaves an incorrect integer-width assumption. Materialize constant
results, reject actual NULL values, and compare against zero in the
comparator's own integer type, preserving LARGEINT signs without narrowing.
Reject non-integer comparator return types during preparation. Add unit and
regression coverage, and keep nested binding tests valid by wrapping their
array-valued bodies in an integer-valued cardinality mock.
### Release note
Fix BE crashes when ARRAY_SORT lambda comparators return nullable or wider
integer values. NULL and non-integer comparator results report query errors.
### Check List (For Author)
- Test:
- Unit Test: 13 related ArrayMapFunctionTest array_sort tests passed
under ASAN.
- Regression test: test_array_sort_lambda_comparator passed during
output generation and normal verification; 7 existing and 9 new output sections
verified.
- Manual test: the reported SQL returns [3, 2, 1]; a NULL comparator
reports an error and the reported SQL succeeds afterward.
- Validation: build.sh --be (ASAN), clang-format v16, build hygiene, and
clang-tidy passed.
- Behavior changed: Yes; valid integer comparators sort without crashing,
and invalid comparator results fail the query.
- Does this need documentation: No
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
