github-actions[bot] commented on code in PR #69046: URL: https://github.com/apache/doris/pull/69046#discussion_r4272547197
########## contrib/apache-orc: ########## @@ -1 +1 @@ -Subproject commit 5860f94768b94406f31698ac66f4cc3d2a781324 +Subproject commit be0f1b73a7aeb78824a03e0dcb692c50a176d513 Review Comment: [P2] Preserve the ORC reader optimizations in the submodule pointer This moves `apache-orc` back two commits, removing the [lazy decompression scratch-buffer allocation and AArch64 libdeflate changes](https://github.com/apache/doris-thirdparty/compare/be0f1b73a7aeb78824a03e0dcb692c50a176d513...5860f94768b94406f31698ac66f4cc3d2a781324). `BlockDecompressionStream` consequently allocates `inputDataBuffer(pool, blockSize)` for every compressed stream even when chunks are contiguous and never use the scratch buffer. With 256 KiB blocks and 100 nullable string columns (PRESENT/LENGTH/DATA), that is about 75 MiB of avoidable memory per reader, multiplied by parallel readers. `be/CMakeLists.txt` builds and links this submodule, so ordinary ORC scans regress independently of AI profiling; AArch64 ZLIB scans also return to the zlib fallback. Please retain `5860f94768b94406f31698ac66f4cc3d2a781324` or a descendant preserving those changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
