HappenLee commented on code in PR #16772:
URL: https://github.com/apache/doris/pull/16772#discussion_r1107228707
##########
be/src/pipeline/pipeline_fragment_context.cpp:
##########
@@ -90,19 +90,24 @@ namespace doris::pipeline {
PipelineFragmentContext::PipelineFragmentContext(
const TUniqueId& query_id, const TUniqueId& instance_id, int
backend_num,
std::shared_ptr<QueryFragmentsCtx> query_ctx, ExecEnv* exec_env,
- std::function<void(RuntimeState*, Status*)> call_back)
+ std::function<void(RuntimeState*, Status*)> call_back,
Review Comment:
the `call_back` better be const reference
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
