wenzhenghu commented on code in PR #68694:
URL: https://github.com/apache/doris/pull/68694#discussion_r4267288920
##########
be/src/common/logconfig.cpp:
##########
@@ -145,6 +148,7 @@ void custom_prefix(std::ostream& s, const
google::LogMessageInfo& l, void* arg)
s << l.thread_id << std::setfill('0');
s << ' ';
s << l.filename << ':' << l.line_number << "]";
+ append_query_log_identity(s);
Review Comment:
Addressed in
[e8c944b9cb66](https://github.com/apache/doris/commit/e8c944b9cb668c580b1854979a0225a04d80ef76).
`LOG_LONG_STRING` now reserves 256 bytes for the prefix.
`LongLogPreservesFullChunksWithFullInstanceIdentity` uses full query/fragment
IDs and a 65,000-byte payload with a distinct tail, then checks all three
captured chunks reconstruct the exact payload.
The new case passed in the ASAN BE query-log test run.
##########
fe/fe-core/src/main/java/org/apache/doris/qe/ConnectContext.java:
##########
@@ -630,6 +633,7 @@ public AuditEventBuilder getAuditEventBuilder() {
public void setThreadLocalInfo() {
MoreFieldsThread.setConnectContext(this);
+ QueryLogContext.setQueryId(queryId);
Review Comment:
Addressed in
[e8c944b9cb66](https://github.com/apache/doris/commit/e8c944b9cb668c580b1854979a0225a04d80ef76).
`TaskHandler.onEvent` and the servlet filter now call
`ConnectContext.remove()` at entry and in `finally`, covering normal
processing, exceptions, and TRACE rejection. Entry cleanup prevents the next
scope from saving an earlier task/request's identity as its previous context.
Added normal/error worker-reuse tests and a TRACE-rejection test; the
independent FE test run passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
