CalvinKirs commented on PR #67286:
URL: https://github.com/apache/doris/pull/67286#issuecomment-6160363794
<!-- doris-repo-review:v1:begin -->
### Local pipeline review — ✅ PASS
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#67286
commit: 785744e577ae64ae697746b84215132fd7e3a492
base: 0cfc81c6163b79a6717e165e4c9dc1c8e27faa60
reviewed_at: 2026-10-14T11:40+08:00
reviewer: CalvinKirs
model: gpt-6.1-sol
effort: high
findings: {blocker: 0, major: 0, minor: 0, nit: 0}
rounds: 1
converged: true
```
**Notes for maintainers**
-
`fe/fe-extension-loader/src/main/java/org/apache/doris/extension/loader/DirectoryPluginRuntimeManager.java:290`
— The previous review issue is fixed: unreadable or unresolved defining-JAR
metadata fails at `STAGE_API_VERSION` before factory construction or
publication; genuinely absent declarations remain eligible for the legacy
mapping.
-
`fe/fe-extension-loader/src/main/java/org/apache/doris/extension/loader/ManifestVersions.java:106`
— Missing defining-JAR locations remain authoritative, preventing substitution
by another candidate containing the same factory class. Only authentication
opts into legacy API 1.0; other plugin families remain strict.
- Repair validation: 59 relevant unit tests and Checkstyle passed. Two
full-review lanes and one test-risk lane covered all seven changed files; the
verdict converged in round 1 with no findings. Full FE packaging was not
completed because incomplete native third-party dependencies triggered an
unrelated rebuild, which was stopped.
<sub>Reviewed locally with the `doris-repo-review` pipeline (a local port of
`.github/workflows/code-review-runner.yml`). This is not a CI status
check.</sub>
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
