This is an automated email from the ASF dual-hosted git repository.
suxiaogang223 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 1f3cd9092fb [fix](be) Use ConfigValidatorTest fixture consistently
(#69009)
1f3cd9092fb is described below
commit 1f3cd9092fbc9151a3cc038d36e32aef68bd8357
Author: Socrates <[email protected]>
AuthorDate: Wed Oct 14 00:29:14 2026 +0800
[fix](be) Use ConfigValidatorTest fixture consistently (#69009)
### What problem does this PR solve?
Issue Number: None
Related PR: #67228
Problem Summary:
PR #67228 added `LookupConnectionCacheBlockPoolSize` with `TEST` to the
existing `ConfigValidatorTest` suite, while the suite already uses
`TEST_F`. GoogleTest requires all tests in a suite to use the same
fixture declaration and fails during test registration:
```text
All tests in the same test suite must use the same test fixture
```
Change the new case to `TEST_F` so it uses the existing fixture
consistently.
### Release note
None
### Check List (For Author)
- Test: No need to test (one-line GoogleTest fixture declaration
correction)
- Behavior changed: No
- Does this need documentation: No
---
be/test/common/config_validator_test.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/be/test/common/config_validator_test.cpp
b/be/test/common/config_validator_test.cpp
index 122709cf8a9..a19d3a209b6 100644
--- a/be/test/common/config_validator_test.cpp
+++ b/be/test/common/config_validator_test.cpp
@@ -83,7 +83,7 @@ TEST_F(ConfigValidatorTest, Validator) {
EXPECT_EQ(cfg_validator_2, 8);
}
-TEST(ConfigValidatorTest, LookupConnectionCacheBlockPoolSize) {
+TEST_F(ConfigValidatorTest, LookupConnectionCacheBlockPoolSize) {
const auto old_value =
config::get_lookup_connection_cache_block_pool_size();
EXPECT_TRUE(config::set_config("lookup_connection_cache_block_pool_size",
"1").ok());
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
