liaoxin01 commented on code in PR #68348:
URL: https://github.com/apache/doris/pull/68348#discussion_r4260754429
##########
be/src/io/cache/block_file_cache.cpp:
##########
@@ -403,6 +403,10 @@ BlockFileCache::BlockFileCache(const std::string&
cache_base_path,
_cache_base_path.c_str(), "file_cache_lru_dump_latency_us");
_recycle_keys_length_recorder = std::make_shared<bvar::LatencyRecorder>(
_cache_base_path.c_str(), "file_cache_recycle_keys_length");
+ _deleting_blocks_length_recorder = std::make_shared<bvar::LatencyRecorder>(
Review Comment:
Thanks, good point. A LatencyRecorder was the wrong type here: the value is
a gauge sampled once per GC round, so its qps and percentiles are meaningless,
and it adds about 10 series per cache path. I replaced it with a
`bvar::Status<size_t>` named `file_cache_deleting_block_count`, which is one
series per path, like the other gauges such as
`file_cache_normal_queue_element_count`. I kept the
`file_cache_recycle_deleting_blocks` Adder, because it is the only signal that
a reference holder dropped a deleting block without going through the holder
path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
