mrhhsg commented on code in PR #68032:
URL: https://github.com/apache/doris/pull/68032#discussion_r4257452811
##########
be/src/exec/spill/spill_file_manager.cpp:
##########
@@ -431,10 +622,10 @@ void SpillFileManager::gc(int32_t max_work_time_ms) {
LOG(INFO) << msg;
}
}};
- _retry_pending_query_spill_directories();
- for (const auto& [path, store_dir] : _spill_store_map) {
+ _retry_pending_spill_directories();
Review Comment:
Follow-up in faa50f63417: `stop()` and the `SpillFileManager` destructor no
longer retry remote deletions; they retry local directories only, so an
unavailable object store cannot hold up `ExecEnv::destroy()` (the only path
that reaches them; the default BE exit `_exit`s without it). Remote prefixes
still pending at exit are left to the lifecycle rule, as before. The GC thread
keeps the time-sliced, rotating retry described above; the test also checks
that `stop()` sends no delete request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
