github-actions[bot] commented on code in PR #69018:
URL: https://github.com/apache/doris/pull/69018#discussion_r4257310464
##########
be/CMakeLists.txt:
##########
@@ -601,6 +601,8 @@ set(CMAKE_CXX_FLAGS "${CXX_COMMON_FLAGS} ${CMAKE_CXX_FLAGS}
${EXTRA_CXX_FLAGS}")
set(CMAKE_C_FLAGS ${CMAKE_CXX_FLAGS})
+add_subdirectory(${CONTRIB_PATH}/h3-cmake ${PROJECT_BINARY_DIR}/h3)
Review Comment:
[P1] Initialize H3 in the standalone BE unit-test entry point. This
unconditional add_subdirectory also runs when run-be-ut.sh configures BE with
MAKE_TEST=ON. That script initializes only the five existing submodules
(run-be-ut.sh:254-261), so on a fresh checkout or worktree contrib/h3 is still
empty when the wrapper reads contrib/h3/VERSION. CMake fails before any BE unit
tests can build, including FunctionH3Test. Please add the matching H3
initialization to run-be-ut.sh; the update added only to build.sh does not
cover that entry point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
