github-actions[bot] commented on code in PR #69001:
URL: https://github.com/apache/doris/pull/69001#discussion_r4255391430
##########
fe/fe-core/src/test/java/org/apache/doris/common/util/BrokerUtilTest.java:
##########
@@ -125,4 +126,29 @@ public void parseColumnsFromPath() {
}
+ @Test
+ public void parseColumnsFromPathPreservesNullMetadataAndInputKeys() throws
Exception {
+ // A case-insensitive parse lowercases its own copy of the keys, not
the caller's list, and turns the Hive
+ // default partition into SQL NULL.
+ List<String> partitionKeys = Lists.newArrayList("region", "dt");
Review Comment:
[P2] Use mixed-case keys to exercise input-list preservation
Both caller keys are already lowercase, so normalizing the caller's list in
place (for example, with columnsFromPath.replaceAll(String::toLowerCase)) would
still produce the expected values/null flags and pass the assertion that
partitionKeys is unchanged. This leaves the input-key preservation invariant
named by this test unprotected. Initialize partitionKeys with mixed-case names
such as Region and Dt, then assert those original spellings after the
case-insensitive parse so that this regression fails the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
