OIiveirra commented on code in PR #68791:
URL: https://github.com/apache/doris/pull/68791#discussion_r4255343722
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/scan/FederationBackendPolicy.java:
##########
@@ -280,12 +297,15 @@ public Multimap<Backend, Split>
computeScanRangeAssignment(List<Split> splits) t
}
case RANDOM: {
randomCandidates.reset();
- candidateNodes =
selectNodes(Config.split_assigner_min_random_candidate_num, randomCandidates);
+ candidateNodes = consistentHashSpreadNum == 0 ?
backends
+ :
selectNodes(Config.split_assigner_min_random_candidate_num, randomCandidates);
break;
}
case CONSISTENT_HASHING: {
candidateNodes = consistentHash.getNode(split,
-
Config.split_assigner_min_consistent_hash_candidate_num);
+ consistentHashSpreadNum == 0 ? backends.size()
+ : isSpreadEnabled() ?
Math.min(consistentHashSpreadNum, backends.size())
Review Comment:
@924060929 Fixed the remaining Remote Doris case from
https://github.com/apache/doris/pull/68791#discussion_r4254051382 in
5d584fce627. RemoteDorisSplit now captures an immutable identity from a
length-prefixed URI and the ticket's remaining bytes when constructed. Reading
an independent read-only buffer preserves the execution buffer's position,
limit and mark; the actual ticket and URI sent to BE are unchanged.
Added coverage for the same URI with different tickets, equal-work identity,
subsequent buffer mutation, heap/direct/read-only buffers, and eight eligible
BEs with spread=2. The latter verifies that distinct tickets escape a single
candidate pair and each assignment remains within its own candidates.
All 82 targeted FE/connector tests passed (0 failures/errors/skips),
including the existing 8 RemoteDorisScanNode tests; the standard clean FE build
and Checkstyle passed. The first scan-node test run hit unresolved
extension-loader types in existing compiled artifacts; after a cache-disabled
clean build, the full test selection passed without unrelated source changes.
This is local verification, not a completed TeamCity result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
