github-actions[bot] commented on code in PR #68574:
URL: https://github.com/apache/doris/pull/68574#discussion_r4245875690
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/plans/commands/ExecuteCommand.java:
##########
@@ -251,7 +251,6 @@ private StatementContext
refreshPreparedPlan(PreparedStatementContext preparedSt
}
reparsedStatementContext.setPlaceholders(refreshedPlaceholders);
- reparsedAdapter.setOrigStmt(currentCommand.getOriginalStmt());
executor.setStatementContext(reparsedStatementContext);
Review Comment:
[P2] Update the non-redispatch log before dropping adapter origin
The refreshed adapter still has a consumer at `StmtExecutor.java:1362`: the
warning for a plan that cannot be redispatched reads
`parsedStmt.getOrigStmt().originStmt`. A concrete path is to execute and cache
a point query on a local row-store MoW table, then drop that table and replace
its name with a view over a remote Doris table whose catalog has
`use_arrow_flight=true`. `isReusable()` rejects the dropped table,
`refreshPreparedPlan()` reparses the statement with a fresh context, replanning
expands the replacement view into a remote scan, and a backend `RpcException`
cancels/closes its remote session. The non-redispatch branch then evaluates
this now-null adapter origin and throws `NullPointerException` before `throw
e`, masking the original error; the removed setter previously prevented that on
this refreshed path. Please use the executor's retained `originStmt` in that
warning too, and add a regression test for an origin-less adapter with a
non-redispatchable scan and an RPC
failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
