abhinav-phi commented on PR #68730: URL: https://github.com/apache/doris/pull/68730#issuecomment-6098825246
@morrySnow conflict resolved in dbfc088bf2, the branch is mergeable again. master added a NaN sign guard in FloatLiteral.uncheckedCastTo while this branch replaced the string based widening with a binary one, so both edits landed on the same lines. i kept the guard from master for the NaN case and widened every other value in binary. behaviour for a NaN is the same either way, a float to double widening in java keeps the sign of a NaN, i verified that separately before picking this shape rather than deleting the guard. the diff against master is now just the two files, FloatLiteral.java and FloatLiteralTest.java, and the test still asserts both reported cases. the runs on the new head may need the usual trigger again, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
