github-actions[bot] commented on code in PR #68849:
URL: https://github.com/apache/doris/pull/68849#discussion_r4236295702
##########
fe/fe-core/src/main/java/org/apache/doris/cloud/datasource/CloudInternalCatalog.java:
##########
@@ -1300,6 +1300,11 @@ public void removeSchemaChangeJob(long jobId, long dbId,
long tableId, long inde
}
}
+ @Override
+ public void onCreateTableConflict(long dbId, OlapTable table) throws
DdlException {
+ dropMaterializedIndex(dbId, table.getId(), table.getIndexIdList(true),
true);
Review Comment:
[P2] Preserve a retryable cleanup path if this drop fails. `commit_index`
has already removed the losing indexes' PREPARED recycle markers. If
`dropIndex` exhausts its RPC retries before committing a DROPPED marker, for
example during a temporary MetaService outage, this hook throws, but the outer
catch cannot drop the loser by ID because it was never registered. The recycler
has no marker or drop log to discover those committed indexes and tablets after
MetaService recovers. Persist a cleanup record for the losing IDs or add orphan
reclamation before discarding them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
