CalvinKirs commented on PR #68559: URL: https://github.com/apache/doris/pull/68559#issuecomment-5866355262
Local skill review completed at head: no Blocker, Major, Minor or Nit finding outstanding. Full report: https://github.com/apache/doris/pull/68559#pullrequestreview-5335912259 One pass in the main session with the repo `code-review` skill, attested below. It read the whole diff at head, tests included, and traced the call chain: `SetPassVarOp` and `AlterUserInfo` are the only SQL entry points to `Auth.setPassword` / `Auth.alterUser`, replay bypasses validation, and a forwarded statement keeps the exact current identity (`FEOpExecutor` sends `toThrift()`, `ConnectProcessor.proxyExecute` restores it with `fromThrift()`), so real root still passes on the master. It raised nothing. Local builds, FE UT and the `account_p0` regression suites ran on this head's tree. <!-- doris-repo-review:v1:begin --> ```yaml schema: doris-repo-review/v1 status: PASS pr: apache/doris#68559 commit: 1d6e9eb63251e676339d3169131e975733cf16cf base: e429e59bdfcf1e555824867a0ed6190828b5ff3b reviewed_at: 2026-09-28T16:31:34+08:00 reviewer: CalvinKirs model: claude-fable-5-1 effort: xhigh findings: {blocker: 0, major: 0, minor: 0, nit: 0} rounds: 1 converged: true ``` <!-- doris-repo-review:v1:end --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
