github-actions[bot] commented on code in PR #68496: URL: https://github.com/apache/doris/pull/68496#discussion_r4119490639
########## regression-test/suites/datatype_p0/agg_state/map/map.groovy: ########## @@ -21,6 +21,9 @@ import java.nio.charset.StandardCharsets import java.nio.file.Files import java.nio.file.Paths +// TODO: Restore this suite with assertions that allow any duplicate-key winner. +// Partial-state merge order is not guaranteed, so a fixed MAP value is not a stable expectation. +/* Review Comment: [P2] Keep MAP_AGG_STATE merge coverage running. This block comment disables the entire suite, including the only `map_agg_merge` regression query under `regression-test/suites`. The new preaggregation check also accepts matching GENERIC MAP_AGG states, so that path loses its existing end-to-end guard. Please keep the suite active with unique map keys for deterministic output or assert the valid duplicate-key winners without fixing their order. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
