morrySnow commented on code in PR #68543:
URL: https://github.com/apache/doris/pull/68543#discussion_r4120475577


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/OrExpansion.java:
##########
@@ -159,6 +160,14 @@ public Plan visitLogicalJoin(LogicalJoin<? extends Plan, ? 
extends Plan> join, O
         if (join.getJoinType().isInnerJoin()) {
             joins.addAll(expandInnerJoin(ctx.cascadesContext, 
hashOtherConditions,
                     join, leftProducer, rightProducer, leftCloneToLeft, 
rightCloneToRight));
+        } else if (join.getJoinType().isRightOuterJoin()) {
+            // right outer join = inner join union right anti join
+            // right anti join is built as left anti join with swapped 
producers,
+            // so that unmatched rows of the right child are kept and left 
side is padded with null

Review Comment:
   fix in another PR



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to