CalvinKirs commented on PR #68549: URL: https://github.com/apache/doris/pull/68549#issuecomment-5866178327
Local skill review completed at head: no Blocker or Major finding, two Minor and two Nit findings outstanding (none blocking). Full report: https://github.com/apache/doris/pull/68549#pullrequestreview-5335767986 Round 1 ran the repo `code-review` skill the way the review runner does: a main-session pass, then two subagents over a shared ledger, one tracing every caller of `checkWithCookie` and the `/rest/v1` routing in both deployment modes, one on the unit test, the regression suite across cloud / TLS / multi-FE runs, and the description. The main session checked every candidate against the code and kept four. Round 2, attested below, was a further main-session pass over the whole diff at this head (check order in the Basic branch including the certificate path, parity with the cookie branch, login's identity on both branches, remaining `checkAuthWithCookie` callers, test isolation); it raised nothing new. The FE build, the unit tests and the regression suite were run on the base below. <!-- doris-repo-review:v1:begin --> ```yaml schema: doris-repo-review/v1 status: PASS pr: apache/doris#68549 commit: 7f278ac77c3a129925c3550378b6e49e90a71560 base: eb50752c0216732ba69f0c04fdabd9b79ac7dda7 reviewed_at: 2026-09-28T16:19:22+08:00 reviewer: CalvinKirs model: claude-fable-5-1 effort: xhigh findings: {blocker: 0, major: 0, minor: 2, nit: 2} rounds: 2 converged: true ``` <!-- doris-repo-review:v1:end --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
