CalvinKirs commented on PR #68555: URL: https://github.com/apache/doris/pull/68555#issuecomment-5865919996
Local skill review completed at head: no Blocker, Major, Minor or Nit finding outstanding. Full report: https://github.com/apache/doris/pull/68555#pullrequestreview-5335591645 Two passes in the main session with the repo `code-review` skill, both attested below. Pass 1 read the whole diff at `8b36ddd` and raised one Nit (commit message and two test comments longer than needed), fixed in `414a444` with no code change. Pass 2 re-read the whole diff at head and traced the call chain again: both GRANT and REVOKE reach `checkTablePrivileges` and are its only callers, replay bypasses validation, runtime-built predicates translate through `AccessTranslation.requirementOf`, and the `.out` blocks match the inserted row. It raised nothing new. Local builds and tests ran at `8b36ddd`, whose tree differs from head only in comments. <!-- doris-repo-review:v1:begin --> ```yaml schema: doris-repo-review/v1 status: PASS pr: apache/doris#68555 commit: 414a4449543e7464aedbf591869bb9d7d4fe759f base: 152213c21eb3e85e8534965279d447da5b0cded9 reviewed_at: 2026-09-28T16:04:30+08:00 reviewer: CalvinKirs model: claude-fable-5-1 effort: xhigh findings: {blocker: 0, major: 0, minor: 0, nit: 0} rounds: 2 converged: true ``` <!-- doris-repo-review:v1:end --> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
