wyxxxcat commented on code in PR #68322:
URL: https://github.com/apache/doris/pull/68322#discussion_r4119383230


##########
cloud/src/recycler/recycler.cpp:
##########
@@ -3710,7 +3707,37 @@ int InstanceRecycler::recycle_tablets(int64_t table_id, 
int64_t index_id,
                 }
             }
         }
-        if (is_multi_version) {
+        if (should_recycle_versioned_keys()) {
+            // Remove tablet indexes in the same transaction as tablet 
metadata.
+            for (const auto& tablet_info : tablets_info) {
+                std::string versioned_idx_key =
+                        versioned::tablet_index_key({instance_id_, 
tablet_info.tablet_id});
+                std::string tablet_index_val;
+                TxnErrorCode err = txn->get(versioned_idx_key, 
&tablet_index_val);

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to