This is an automated email from the ASF dual-hosted git repository.
HappenLee pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/master by this push:
new 07587cc7f44 [fix](function) correct misleading aliases for
FunctionNextDay and FunctionPreviousDay (#68528)
07587cc7f44 is described below
commit 07587cc7f44f8518e51f9d337722fa26e157da1e
Author: yy782 <[email protected]>
AuthorDate: Mon Sep 28 14:02:02 2026 +0800
[fix](function) correct misleading aliases for FunctionNextDay and
FunctionPreviousDay (#68528)
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
The type aliases for `next_day` / `previous_day` are swapped relative to
their
semantics:
```cpp
using FunctionNextDay = FunctionRelativeDay<true>; // true =>
"previous_day"
using FunctionPreviousDay = FunctionRelativeDay<false>; // false =>
"next_day"
```
`FunctionRelativeDay<IsPrevious>` derives its registered name from the
template
parameter: `IsPrevious ? "previous_day" : "next_day"`. So
`FunctionNextDay` is
actually aliased to the `previous_day` implementation, and vice versa.
This is purely a naming issue and does **not** change runtime behavior,
because
registration (`SimpleFunctionFactory::register_function<T>()`) uses the
static
`T::name` member rather than the type alias itself. The behavior of
`next_day`
and `previous_day` remains correct; only the alias names are misleading
to
readers.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [x] No need to test or manual test. Explain why:
- [x] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [x] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR
should merge into -->
---
be/src/exprs/function/function_date_or_datetime_computation.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/be/src/exprs/function/function_date_or_datetime_computation.h
b/be/src/exprs/function/function_date_or_datetime_computation.h
index c631504fd6b..f81ff42242e 100644
--- a/be/src/exprs/function/function_date_or_datetime_computation.h
+++ b/be/src/exprs/function/function_date_or_datetime_computation.h
@@ -1856,8 +1856,8 @@ private:
}
};
-using FunctionNextDay = FunctionRelativeDay<true>;
-using FunctionPreviousDay = FunctionRelativeDay<false>;
+using FunctionNextDay = FunctionRelativeDay<false>;
+using FunctionPreviousDay = FunctionRelativeDay<true>;
class FunctionTime : public IFunction {
public:
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
