TsukiokaKogane opened a new pull request, #68514:
URL: https://github.com/apache/doris/pull/68514
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
When FE enable_feature_binlog=false, CREATE TABLE could still create enabled
ROW binlog tables, including through inherited properties, LIKE, and CTAS.
Commits to existing
ROW binlog tables could also bypass TSO allocation and succeed with an
invalid timestamp. Meanwhile, legacy checks incorrectly applied this
ROW-specific switch to CCR
recording, metadata, and checkpoint handling.
This change validates the effective ROW binlog configuration before table
creation produces side effects and requires existing ROW tables to obtain a
valid TSO before
committing. It preserves binlog properties in SHOW CREATE, rejects ROW
configuration changes while the feature is disabled, and keeps CCR operations
independent of the
switch. It also fixes commit failure handling to prevent callback state
and lock leaks.
Already committed transactions remain publishable and replayable after the
switch is disabled. FE unit tests cover these boundaries, including local and
Cloud transaction
paths.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
