github-actions[bot] commented on code in PR #16578:
URL: https://github.com/apache/doris/pull/16578#discussion_r1102188127
##########
be/test/olap/rowset/segment_v2/inverted_index_searcher_cache_test.cpp:
##########
@@ -115,14 +117,14 @@ TEST_F(InvertedIndexSearcherCacheTest, insert_lookup) {
// not use cache
InvertedIndexCacheHandle inverted_index_cache_handle_2;
status = index_searcher_cache->get_index_searcher(fs, kTestDir,
file_name_not_exist_2,
-
&inverted_index_cache_handle_2, false);
+
&inverted_index_cache_handle_2, &stats, false);
EXPECT_EQ(Status::OK(), status);
EXPECT_TRUE(inverted_index_cache_handle_2.owned);
EXPECT_EQ(nullptr, inverted_index_cache_handle_2._cache);
Review Comment:
warning: '_cache' is a private member of
'doris::segment_v2::InvertedIndexCacheHandle' [clang-diagnostic-error]
```cpp
EXPECT_EQ(nullptr, inverted_index_cache_handle_2._cache);
^
```
**be/src/olap/rowset/segment_v2/inverted_index_cache.h:159:** declared
private here
```cpp
Cache* _cache = nullptr;
^
```
##########
be/test/olap/rowset/segment_v2/inverted_index_searcher_cache_test.cpp:
##########
@@ -115,14 +117,14 @@
// not use cache
InvertedIndexCacheHandle inverted_index_cache_handle_2;
status = index_searcher_cache->get_index_searcher(fs, kTestDir,
file_name_not_exist_2,
-
&inverted_index_cache_handle_2, false);
+
&inverted_index_cache_handle_2, &stats, false);
EXPECT_EQ(Status::OK(), status);
EXPECT_TRUE(inverted_index_cache_handle_2.owned);
EXPECT_EQ(nullptr, inverted_index_cache_handle_2._cache);
EXPECT_EQ(nullptr, inverted_index_cache_handle_2._handle);
Review Comment:
warning: '_handle' is a private member of
'doris::segment_v2::InvertedIndexCacheHandle' [clang-diagnostic-error]
```cpp
EXPECT_EQ(nullptr, inverted_index_cache_handle_2._handle);
^
```
**be/src/olap/rowset/segment_v2/inverted_index_cache.h:160:** declared
private here
```cpp
Cache::Handle* _handle = nullptr;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
