manesioz opened a new pull request, #68506:
URL: https://github.com/apache/doris/pull/68506
### What problem does this PR solve?
Issue Number: close #68505
Related PR: None
Problem Summary:
`HTTP_COUNTER_COPY_INFO_QUERY_ERR` was registered with the name
`http_copy_into_upload_err_total`, which is the name of
`HTTP_COUNTER_COPY_INFO_UPLOAD_ERR`. The FE `/metrics` endpoint therefore
exported two `doris_fe_http_copy_into_upload_err_total` series with the same
name and labels, and no `doris_fe_http_copy_into_query_err_total` series.
This PR changes the name to `http_copy_into_query_err_total`, which matches
the other copy-into counters. `CopyIntoAction` already increments this counter
only on the query path, so no other change is necessary.
### Release note
Fix the FE metric `doris_fe_http_copy_into_query_err_total`. Before this
fix, copy-into query errors were exported under the duplicate name
`doris_fe_http_copy_into_upload_err_total`.
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [x] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [x] Other reason <!-- Add your reason? --> The change only
corrects a metric name string.
- Behavior changed:
- [ ] No.
- [x] Yes. <!-- Explain the behavior change --> Copy-into query errors
are exported as `doris_fe_http_copy_into_query_err_total` instead of a second
`doris_fe_http_copy_into_upload_err_total` series.
- Does this need documentation?
- [x] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
