Tanya-W commented on code in PR #16569:
URL: https://github.com/apache/doris/pull/16569#discussion_r1101532377
##########
fe/fe-core/src/main/java/org/apache/doris/planner/OriginalPlanner.java:
##########
@@ -436,6 +441,60 @@ private void pushSortToOlapScan() {
}
}
+ /**
+ * outputColumnUniqueIds contain columns in OrderByExprs and outputExprs
+ * push output column unique id set to olap scan.
+ */
+ private void pushOutColumnUniqueIdsToOlapScan(PlanFragment rootFragment,
Analyzer analyzer) {
+ HashSet<Integer> outputColumnUniqueIds = new HashSet<>();
+ ArrayList<Expr> outputExprs = rootFragment.getOutputExprs();
+ for (Expr expr : outputExprs) {
+ if (expr instanceof SlotRef) {
+ if (((SlotRef) expr).getColumn() != null) {
+ outputColumnUniqueIds.add(((SlotRef)
expr).getColumn().getUniqueId());
+ }
+ }
+ }
+
+ for (PlanFragment fragment : fragments) {
+ PlanNode node = fragment.getPlanRoot();
+ PlanNode parent = null;
+ while (node.getChildren().size() != 0) {
+ for (PlanNode childNode : node.getChildren()) {
+ List<SlotId> outputSlotIds = childNode.getOutputSlotIds();
+ if (outputSlotIds != null) {
+ for (SlotId sid : outputSlotIds) {
+ SlotDescriptor slotDesc =
analyzer.getSlotDesc(sid);
+ outputColumnUniqueIds.add(slotDesc.getUniqueId());
+ }
+ }
+ }
+ // OlapScanNode is the last node.
+ // So, just get the two node and check if they are SortNode
and OlapScan.
+ parent = node;
+ node = node.getChildren().get(0);
+ }
+
+ if (parent instanceof SortNode) {
Review Comment:
GROUP BY columns must in SELECT output columns list
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
