github-actions[bot] commented on code in PR #68390:
URL: https://github.com/apache/doris/pull/68390#discussion_r4092718835
##########
fe/fe-core/src/main/java/org/apache/doris/job/extensions/mtmv/MTMVTask.java:
##########
@@ -862,41 +1070,53 @@ &&
hasUnusableIvmStreamForPartitions(partitionPlan.context, needRefreshPartition
if (refreshMode == MTMVTaskRefreshMode.NOT_REFRESH) {
return true;
}
- writeIvmBaselineBarrier(RefreshMode.PARTITIONS);
- executePartitionBasedRefresh(partitionPlan.context,
RefreshMode.PARTITIONS, ctx);
+ executePartitionBasedRefresh(partitionPlan.context,
RefreshMode.PARTITIONS, ctx,
+ partitionPlan.partitions);
return true;
}
Review Comment:
[P1] Restore a durable rebuild requirement before this IVM PARTITIONS
overwrite. Selected PCT RESET scans advance source offsets in the insert
transaction, but `InsertOverwriteTableCommand` commits that transaction into
temp partitions before the later live-partition swap. A failure or master
switch in between drops the temp partitions without rewinding those offsets;
because the old pre-DML barrier was removed and epochs are published only after
the whole command returns, the old live rows and clean nonzero epochs remain
after their delta was consumed. Please establish a durable requirement for
`partitionPlan.partitions` before execution, ensure this full-rebuild scope is
not clamped by stale `ivmPlannedEpochs` from an earlier attempt, and add a
failure/failover test at the commit-to-replace boundary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
