airborne12 commented on code in PR #67180: URL: https://github.com/apache/doris/pull/67180#discussion_r4092069960
########## be/src/common/config.cpp: ########## @@ -1319,6 +1319,7 @@ DEFINE_Bool(enable_inverted_index_cache_check_timestamp, "true"); DEFINE_mBool(enable_inverted_index_correct_term_write, "true"); DEFINE_Int32(inverted_index_fd_number_limit_percent, "20"); // 20% DEFINE_Int32(inverted_index_query_cache_shards, "256"); +DEFINE_mDouble(inverted_index_candidate_pushdown_ratio, "0.1"); Review Comment: Follow-up to my previous reply: the atomic snapshot alone did not serialize two set_config writers. Commit 957e6eabc1c adds a mutex for this ratio around the existing assignment, validation, and callback sequence, so an inf request cannot validate against another request's value and then publish. The scan-side atomic getter remains. A concurrent valid/inf update test, the ASAN BE build, and 19 targeted unit tests passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
