mrhhsg commented on code in PR #68428:
URL: https://github.com/apache/doris/pull/68428#discussion_r4084289240
##########
be/src/exprs/function/function_regexp.cpp:
##########
@@ -55,6 +55,20 @@
namespace doris {
+static bool advance_re2_search_position(const char* data, size_t size,
+ const re2::StringPiece& match, size_t&
pos) {
+ const size_t match_pos = match.data() - data;
+ if (match.empty()) {
+ if (match_pos == size) {
+ return false;
+ }
+ pos = match_pos + 1;
Review Comment:
Addressed in 31fbc6e9a36: empty RE2 matches now advance by one decoded UTF-8
character, while malformed input falls back to one-byte progress. Added valid
multibyte and malformed-byte BE unit coverage for regexp_count and both
extract-all forms, plus a generated and rerun multibyte regression case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
