lets-order-some-fries commented on PR #67007: URL: https://github.com/apache/doris/pull/67007#issuecomment-5778677688
Superseded — closing this myself. #67338 (merged 7 Sep) marked both `tls_private_key_password` and `key_store_password` as `@ConfField(sensitive = true)`, along with several other configs. That is the same change this PR proposed, so the production half of it is already on master and this PR has nothing left to add. The one thing #67338 did not bring with it is test coverage: `ConfigTest` still has no case pinning the masking of those two fields, though `fe_meta_auth_token` and `auth_token` each have one. I've opened #68395 with just that test, on current master, run locally. Thanks to everyone who worked on #67338. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
