HappenLee commented on PR #67817:
URL: https://github.com/apache/doris/pull/67817#issuecomment-5773741150
Local source review completed for PR #67817, head
665465826784b5c3115fcca0c7243c3a4c2fba4c against base
9fb32d2bbf2818d0bb644086868b9689b92ca841.
Two review rounds covered the ARRAY reader, offset endpoint construction,
item-range coalescing, append/null/lazy behavior, ownership and error paths,
existing tests, and the actual production callers. The first round identified a
repeated-final-row synthetic counterexample. The second round traced
reachability and withdrew that finding as a blocking production defect: scan
row IDs come from a bitmap; row-ID fetch sorts and deduplicates; fixed partial
updates receive key-aggregated blocks; flexible partial updates aggregate
before planning reads; publish-conflict plans are local to one segment; and
row-binlog retrievers are created per block. No currently reachable correctness
regression was found in those paths. The current head also retains the per-row
fallback for unordered requests.
The two remaining minor, non-blocking follow-ups are to document/test the
unique-row-ID fast-path contract, and to extend real-file or SQL coverage for
nested ARRAY/STRUCT predicate-filter-lazy materialization. They do not
establish additional production defects.
Validation: source inspection, all applicable checkpoints in the repository
code-review skill, build-hygiene checks and diff whitespace checks. An isolated
endpoint-index model passed 263,874 strictly increasing selections; it is not a
BE integration test. No local BE build, BE unit-test run or SQL regression was
executed. The author's benchmark and current hosted check results were
inspected, but the benchmark was not rerun. The benchmark supports sparse-read
benefit with an explicit temporary-memory trade-off, not universal query
speedup.
This records the local review result through the repository's existing
review-result workflow. It does not replace required code-owner approval or
other required checks.
<!-- doris-repo-review:v1:begin -->
```yaml
schema: doris-repo-review/v1
status: PASS
pr: apache/doris#67817
commit: 665465826784b5c3115fcca0c7243c3a4c2fba4c
base: 9fb32d2bbf2818d0bb644086868b9689b92ca841
reviewed_at: 2026-09-22T08:51:41+00:00
reviewer: HappenLee
model: gpt-6-astra
effort: xhigh
findings: {blocker: 0, major: 0, minor: 2, nit: 0}
rounds: 2
converged: true
```
<!-- doris-repo-review:v1:end -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
